Bug #1132

Changing graphical settings doesn't display in UI

Added by Spyhawk 8 months ago. Updated 7 months ago.

Status:Fixed% Done:

100%

Priority:NormalSpent time:-
Assignee:Spyhawk
Category:Mod UI
Target version:2.77
OS: Arch:

Description

Changing graphical settings that requires vid_restart don’t display in UI before the game is restarted.

Harlekin:
it does not show the changes.

IR4:
mapoverbrightbits is latched cvar
it requires a restart

Harlekin: i made a more options for et vanilla and there it shows changes

Note: These are latched cvars. A popup that ask to restart right awyas might do the trick.
See modification by Harlekin too.

bug.jpg - option with vid_restart (107 KB) Spyhawk, 22.12.2018 22:13

shot0008.jpg - Harlekin modded settings (62.3 KB) Spyhawk, 22.12.2018 22:16

944
945

Associated revisions

Revision e6107e77
Added by Spyhawk 8 months ago

ui: fixed latched cvars change not displayed, refs #1132

Revision 7b009293
Added by Spyhawk 8 months ago

ui: removed broken gamma setting from profile creation, refs #1132

Revision 07155343
Added by Spyhawk 8 months ago

ui: removed broken ui_r_gamma, refs #1132

Revision 538853ad
Added by Spyhawk 8 months ago

ui: introduced ui_cl_lang, refs #1132

Revision 21ee34a6
Added by Spyhawk 7 months ago

client: fixed vid_restart not reinitializing i18n, refs #1132

History

#1 Updated by Spyhawk 8 months ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 50

The above mentioned settings are now fixed in UI.
The language selection (cl_lang) still needs to be fixed. It requires more than a vid_restart.

#2 Updated by Spyhawk 8 months ago

  • Target version changed from 2.76 to 2.78
  • % Done changed from 50 to 80

I moved the language settings from the game options to the system options page, so it can reused the same logical code of vid_restart.
However, the latched cl_lang requires a complete restart of the application. It is probably possible to introduce a check in case cl_lang has been modified and implement a complete client restart. but this is not something I want to dive in so close to release (it might breaks the client a bit...).

Delaying this last part to the next release. The other graphical options should behave and update correctly.

#3 Updated by Spyhawk 7 months ago

  • Target version changed from 2.78 to 2.77

#4 Updated by Spyhawk 7 months ago

  • Status changed from In Progress to Fixed
  • % Done changed from 80 to 100

#5 Updated by IR4T4 7 months ago

  • Assignee set to Spyhawk

Also available in: Atom PDF