Bug #1170

Only campaigns in map list when referee

Added by swecide 5 months ago. Updated about 1 month ago.

Status:Fixed% Done:

100%

Priority:NormalSpent time:-
Assignee:-
Category:Mod QAGAME
Target version:2.77
OS: Arch:

Description

As a referee, only the campaigns are visible in the referee menu map list.


Related issues

Related to ET: Legacy Development - Bug #1183: broken nextmap command in gametype 4 New 20.01.2019
Related to ET: Legacy Development - Bug #854: Fix stopwatch doesn't start after map end Fixed 02.08.2015

Associated revisions

Revision 7494df2d
Added by Spyhawk about 1 month ago

Revert "qcommon: Don’t let VMs change engine latch cvars immediately", refs #854 #1170

This reverts commit bbb68d3af07f3025b10e9f593095f8b51d5c2473.

While preventing a potential rare crash in theory, this commit
introduces way too many side effects and issues to be worth keeping.

It also been pointed out this security fixe is fragile, and has
subsequently also been reverted in ioq3. See:
https://github.com/ioquake/ioq3/commit/738465d677bddac1385da7d6099b58ca0c4a797f

History

#1 Updated by IR4T4 5 months ago

  • Target version set to 2.77

#2 Updated by Spyhawk 5 months ago

There is an issue with latched gametype. Servers are started with the default g_gametype (default 4, campaign), even if they’re using map rotation (6) as shipped with the default config. Since the value is latched, the server is still considered running campaign mode and as such only campaign are available in the referee maps menu.
When the next map is loaded (or by using !nextmap), both campaigns and maps can be selected.

#3 Updated by Spyhawk 5 months ago

  • Category changed from Client to Mod QAGAME
  • Status changed from New to Confirmed

#4 Updated by Spyhawk 5 months ago

  • OS deleted (Linux)
  • Arch deleted (64-bit)

#5 Updated by IR4T4 4 months ago

I think I’ve found the reason for the g_gametype issue:

Since some version we are using Cvar_SetSafe instead of Cvar_Set for trap_Cvar_Set mod calls:

        // don't let VMs or server change engine latched cvars instantly
        if ((flags & CVAR_LATCH) && !(flags & CVAR_VM_CREATED))
        {
            force = qfalse;
        }

#6 Updated by Spyhawk about 1 month ago

  • Related to Bug #1183: broken nextmap command in gametype 4 added

#7 Updated by Spyhawk about 1 month ago

  • Related to Bug #854: Fix stopwatch doesn't start after map end added

#8 Updated by Spyhawk about 1 month ago

  • Status changed from Confirmed to Fixed
  • % Done changed from 0 to 100

Also available in: Atom PDF