Feature #1179

Add GeoIP privacy option

Added by Spyhawk 11 months ago. Updated 9 months ago.

Status:Fixed% Done:

100%

Priority:NormalSpent time:-
Assignee:Spyhawk
Category:Mod generic
Target version:2.77
OS: Arch:

Description

GeoIP allows to display country flags on servers. Clients have the ability to display flags on their own scoreboard, but the option itself is server side controlled only and thus subject to some privacy issue.
Add a client side option to prevent the server to display the country of the client if it is disallowed. Keep it simple and use a generic flag instead (UN flag).

This likely requires to extend the clientinfo string (maybe extend cg_uinfo).


Related issues

Related to ET: Legacy Development - Feature #477: Upgrade GeoIP country database to GeoLite2 New 06.01.2014

Associated revisions

Revision 88939a96
Added by ryven 11 months ago

qagame: add geoip privacy option

  • clients can now toggle geolocation sharing using cg_allowGeoIP
    refs #1179

Revision ad8cdc4a
Added by Spyhawk 11 months ago

ui: added GeoIP privacy option, refs #1179

Revision e0144d1b
Added by Spyhawk 9 months ago

cgame: fixed no flag displayed when cg_allowGeoIP is not set, refs #1179

See cg_allowGeoIp which defaults to 1.

History

#1 Updated by Spyhawk 11 months ago

  • Related to Feature #477: Upgrade GeoIP country database to GeoLite2 added

#2 Updated by Spyhawk 11 months ago

  • Description updated (diff)

#3 Updated by Spyhawk 11 months ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

#4 Updated by IR4T4 11 months ago

  • Assignee set to Spyhawk

#5 Updated by Spyhawk 9 months ago

  • Status changed from Fixed to In Progress

Doesn’t seem to be working as expected. Reopening.

#6 Updated by Spyhawk 9 months ago

  • Status changed from In Progress to Feedback

Did some more testing tonight (connecting with 2 clients) and the implementation seems good.

There seem however to be an issue with clients that connect from the 2.76 UI. I guess the cg_allowGeoIP isn’t set client side when connecting, so they appear as "UN" flag (latest `else` catched it, so client→sess.uci = 246;). After a reconnect, everything should be in order. Maybe there is a way to correctly handle this use case, but this would be a temporary issue, and should be gone once players upgrade to the newer release.

#7 Updated by Spyhawk 9 months ago

  • Status changed from Feedback to Fixed

Also available in: Atom PDF