Feature #1281

ingame_main.menu "ADD TO FAVORITES" button

Added by keMoN 6 months ago. Updated 2 months ago.

Status:In Progress% Done:

80%

Priority:NormalSpent time:-
Assignee:-
Category:Mod UI
Target version:2.77
OS: Arch:

Description

Quote from the forums [original post]

Hey there, i finally just managed to create an account here, with my username annoyingly without a space.
But now there is something i need to bring to light.
on the "master" branch of the ET Legacy Source code under /etmain/ui/ingame_main.menu
i find the "ADD TO FAVORITES" Button to be unnecessary since it already exists under "SERVER INFO" (ingame_serverinfo.menu), especially the text looks messy and out-of-place compared to the rest of the menu.
My suggestion would be to remove this button from ingame_main.menu so the menu as a whole is cleaner and more uniform.

side note: the "LIMBO MENU" button should be put directly above the "DISCONNECT" button, it’s a much better spot for it. (matches noquarter too!)

The ingame_main.menu file that has my stated changes is attached below.

- Ets|PsycoPappy 4

ingame_main.menu (2.3 KB) keMoN, 06.05.2019 15:15

Associated revisions

Revision bf97e73c
Added by Spyhawk 5 months ago

ui: allow in-game fav button to add and remove server, refs #1281

Revision 615d4e9a
Added by Spyhawk 5 months ago

ui: reverted unintended change that breaks fav boxes, refs #1281

Revision b035ad7b
Added by Spyhawk 3 months ago

ui: possibly fixed the favorite button functionality, refs #1281

History

#1 Updated by Spyhawk 6 months ago

I’d reject this request. With the new containerized system (#1161), we need an easy way to add server to favorites. The button on serverinfo is way too much hidden (ie, useless).
I assume PsycoPappy isn’t aware of the upcoming changes - and might not like it (if they change the main menu too), but that’s another issue.

#2 Updated by keMoN 6 months ago

  • Target version changed from 2.77 to 2.78

I understand both sides here.
If you want to add the server to your favourites you do that once and after that the button becomes obsolete. Also, does it display "Remove from Favourites" once it’s favourited?^^

I do understand the notion of not wanting a button that is likely used once per ET installation in the menu at all times, but I also understand the need for easy access to add said server.
I guess we should leave it in for 2.77 at least and then maybe reconsider for 2.78 if people already organised their favourites maybe?

Feel free to set to invalid if you don’t see a problem.

#3 Updated by Spyhawk 6 months ago

I think the real problem here is that PsycoPappy (which created the ETs menu) doesn’t realize the "Add to Favorites" button is part of our efforts to prevent admins load any menu to users without their consent.
It’s thus not "unnecessary", but it is indeed "absolutely necessary". It however quite long, maybe we can rename it as "Add as favorite" (1 less character)? Any better suggestion here?

I really like the idea of displaying "Remove Favorite" once it’s added, but I’m not sure is that is possible with the very inflexible UI system.

#4 Updated by PsychoPappy4 6 months ago

ah, i see... you guys do have future plans with this button.

I still think that having a button that’s used once is redundant, and the text is indeed long and out-of-place making it the worst looking button in the menu.

i also think not many people use the favorites system, i used to write down the IP addresses of my favorite servers, since the favorites system was not reliable, i got the IP address through the "SERVER INFO" menu.

now, you guys can add an "ADD TO FAVORITES" button outside the ingame_main menu in it’s own window, since i proved it’s possible with the ETS Menu that i developed.

and also, if you guys are completely against admins loading menus you can incorporate a system that Silent 0.9.0 has, which blocks unofficial menu modifications while still allowing a custom menu to be loaded (ingame only). (also in silent 0.9.0, onOPEN events are ignored.)

Side note: you guys can move the "LIMBO MENU" button down directly above the "DISCONNECT" button, like it is in NoQuarter since honestly it’s the best place for this button, one of you guys can put that in it’s own ticket.

#5 Updated by Spyhawk 6 months ago

Again, you didn’t get it: Favorites will be quite essential in the next release. Customized main menus will be more restricted because of admin abuse, and we already have a working system in place (with some minor details to look at). And its imho much better than silent’s implementation.

Limbo will stay on top. It’s where it should be, because it’s the most important button in the menu. We should probably move it to the very top, actually.

#6 Updated by PsychoPappy4 5 months ago

Honestly though, with the "LIMBO MENU" button i don’t see what’s so hard with just tapping "L" on your keyboard to do the same thing?

it’s how i have done it since i started playing ET when i was 7 years old (2003), it’s much easier and faster than pressing ESC and then clicking "LIMBO MENU".

moving the button to the very top is not exactly a good idea, let alone it’s existence on the menu at all to begin with, (the L key considered.) :\

#7 Updated by Spyhawk 5 months ago

We’re not only maintaining the game for old players, and there are cases where having the button might be useful (unbind). Now, if you have other arguments than "my customized menu will look bad" (which seems to be your actual issue here), we’d be please to hear you. Otherwise, please stop taking valuable time.

#8 Updated by Spyhawk 5 months ago

  • Tracker changed from Task to Feature
  • Status changed from New to Fixed
  • Target version changed from 2.78 to 2.77
  • % Done changed from 0 to 100

Button now works for adding and removing favorites. It’s been shortened to "Favorite" only, with a popup detailing if the fav will be added or removed.

#9 Updated by Spyhawk 5 months ago

  • Status changed from Fixed to In Progress
  • % Done changed from 100 to 90

Not always working as it should. After removing a server (from in-game), the button function isn’t flipped and it won’t propose to add the server, but to remove it again (only happens sometimes...?)

#10 Updated by Spyhawk 3 months ago

  • Status changed from In Progress to Feedback
  • % Done changed from 90 to 100

#11 Updated by Spyhawk 2 months ago

  • Status changed from Feedback to In Progress
  • % Done changed from 100 to 80

Not working yet. The button can be used to remove favorite, but not for adding them.

Also available in: Atom PDF