Feature #1300

Implement PNG format for screenshot

Added by Spyhawk 8 months ago. Updated 26 days ago.

Status:Fixed% Done:

100%

Priority:NormalSpent time:-
Assignee:-
Category:Client
Target version:2.77
OS: Arch:

Description

Screenshot are now only available in TGA or JPG format. Add PNG as a better (default) screenshot format.
Also, reduce the screenshot command to one (so it’s less annoying in console, especially in dev mode) and see if TGA code can be removed entirely.

Associated revisions

Revision 0d1781f7
Added by Spyhawk 8 months ago

renderers: use JPEG for screenshots only, refs #1300

Revision 25bb0bac
Added by Spyhawk 8 months ago

mod: removed cg_useScreenshotJPEG cvar, refs #1300

Revision 41fba9a5
Added by Spyhawk 8 months ago

client: adjusted cl_avidemotype for JPEG only, refs #1300

Revision 44c038d2
Added by Spyhawk 30 days ago

general: added FEATURE_PNG in cmake, refs #1300

Revision 83a8a599
Added by Spyhawk 30 days ago

client: added PNG screenshot support, refs #1300

Revision a19e0273
Added by Spyhawk 30 days ago

renderer: added r_screenshotFormat cvar, refs #1300

Revision c1fec216
Added by Spyhawk 30 days ago

ui: added screenshot options in system options menu, refs #1300

Revision 3e36ab89
Added by Spyhawk 29 days ago

rendercommon: removed unused variable, refs #1300

Revision 59176d87
Added by Spyhawk 28 days ago

general: fixed cmake libpng detection with system libs, refs #1300

Revision 4a634acd
Added by Spyhawk 26 days ago

renderers: added PNG screenshot support in all renderers, refs #1300

History

#1 Updated by Spyhawk 8 months ago

  • Description updated (diff)

#2 Updated by Spyhawk 8 months ago

/screenshot is now using JPEG format. Making a screenshot using TGA format isn’t possible anymore, but the underlying code is still there. It could be accessed again with a new r_screenshotType(?) when PNG is also added.

  • implement PNG rendering (done)
  • add a r_screenshotType cvar to define format (done, using r_screenshotFormat)
  • rework cl_avidemoType (0 and 2 are now JPEG, TGA is not an option anymore) (ok, use above mentioned cvar)
  • adjust UI for new r_ cvar (done in system options)
  • move screenshot code in rendercommon (guess it could be shared across all renderers) (too messy to get it right, so that’s for another time if ever)

#3 Updated by Spyhawk 8 months ago

  • Target version changed from 2.78 to 2.77

(moving to 2.77 so we don’t forget to add format selection cvar - but png support is only a nice to have for the next release)

#4 Updated by Spyhawk 30 days ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 90

#5 Updated by Spyhawk 26 days ago

  • Status changed from In Progress to Fixed
  • % Done changed from 90 to 100

Also available in: Atom PDF