Feature #15

Make va() buffer size safe

Added by IR4T4 about 7 years ago. Updated over 3 years ago.

Status:New% Done:

0%

Priority:Low
Assignee:-
Category:General
Target version:ALL
OS: Arch:

Description

FIXME: make this buffer size safe someday
See va() qcommon/qshared.c

Associated revisions

Revision d4b8a68c
Added by Radegast about 7 years ago

made va buffer size safe by using vsnprintf, fixes #15

Revision d45ef816
Added by IR4T4 over 6 years ago

generic: reverted va() to old implementaion refs #15

History

#1 Updated by Radegast about 7 years ago

  • Category set to General
  • Status changed from New to Fixed
  • Assignee set to Radegast
  • Target version set to 2.70rc1
  • % Done changed from 0 to 100

#2 Updated by IR4T4 over 6 years ago

  • Status changed from Fixed to New
  • Target version changed from 2.70rc1 to 2.71rc1

This new va() it doesn’t do equivalent results as the old implementation. Reverted to old code fixes

- non initalized (orange) shaders on first startup

- shader issue north africa 1of3 thingy

- fireteam code with locations

- missing chars/no new lines in console

... and probably more ...

#3 Updated by Radegast over 6 years ago

  • Assignee changed from Radegast to IR4T4
  • Target version changed from 2.71rc1 to 2.90
  • % Done changed from 100 to 0

IR4T4 wrote:

- non initalized (orange) shaders on first startup

Wow, good catch. I wouldn’t have guessed in a million years that this has something to do with orange shaders. But since va() is now reverted to the old implementation, this bug report should be opened again.

#4 Updated by IR4T4 about 6 years ago

  • Assignee deleted (IR4T4)

#5 Updated by IR4T4 over 3 years ago

  • Target version changed from 2.90 to ALL

Also available in: Atom PDF