Bug #415

ET:L is creating two different etconfig.cfgs

Added by Saukko over 5 years ago. Updated over 5 years ago.

Status:Fixed% Done:

100%

Priority:Normal
Assignee:Spyhawk
Category:General
Target version:2.71rc4
OS: Arch:

Description

As explained in the topic: http://dev.etlegacy.com/boards/3/topics/688?r=690, ET:L creates two different etconfig.cfgs.

When you create a profile at the start, it creates two etconfig.cfg files and they are located in these two folders:

...\MyDocumnets\WolfETL\legacy\
...\MyDocumnets\WolfETL\legacy\profiles\"profile"\

Why not just create one config to the profile folder instead creating one more into "legacy" folder that can be deleted anyway?

-*S


Related issues

Related to ET: Legacy Development - Bug #266: fs_game does not recognize profile New 25.03.2013

Associated revisions

Revision 7b645342
Added by Spyhawk over 5 years ago

general: removed unecessary missing profile fallback, fixes #415

Revision 1d1e699b
Added by Spyhawk over 5 years ago

general: removed unecessary missing profile fallback, fixes #415

History

#1 Updated by Spyhawk over 5 years ago

At first, having such a fallback feature when the profile is missing didn’t make sense, since the game would ask to create a new profile at startup. When looking at the original ET-GPL sources, we can see that this 'fallback’ feature is related to the com_gameInfo.usesProfiles variable that has been removed from et:legacy a while ago. That code isn’t a fallback code, it is in fact part of the old function that has been left behind and thus can be safely removed.

I’ve also tested various situation, and can confirm the removal doesn’t have any side effect. If the profile isn’t defined, a new one will be created. If the profile exists but the etconfig.cfg file isn’t present for any reason, a new one with default value will be created.

#2 Updated by Radegast over 5 years ago

  • Status changed from New to Fixed
  • Assignee set to Spyhawk
  • % Done changed from 0 to 100

Code that you removed was kept there, so that we could reintroduce compatibility with ETFortress, which doesn’t work with profiles. However, Ensiform said there won’t ever be any new version of ETF and it can’t be open-sourced, so we might as well forget about it.

#3 Updated by Spyhawk over 5 years ago

Thanks Radegast - I haven’t thought about specific mods compatibility. ETF will seemingly never work on ET:L, but I need to check if TC:E compatibility hasn’t been broken by this change.

Edit: TC:E indeed supports multiple profiles, so it isn’t affected by this change.

#4 Updated by Spyhawk over 5 years ago

  • Target version changed from ALL to 2.71rc4

#5 Updated by Spyhawk about 2 years ago

  • Related to Bug #266: fs_game does not recognize profile added

Also available in: Atom PDF