Bug #49

Test NET_AdrToString and associated code for IPv6 addresses / fix q3 net code merge

Added by Trackbase over 6 years ago. Updated about 1 year ago.

Status:In Progress% Done:

50%

Priority:Normal
Assignee:-
Category:General
Target version:ALL
OS: Arch:

Description

The NET_AdrToString function is different then the one from ET:GPL (no port is added)
This results in problems with several mods that rely on an ip:port format in the userinfo.

This issue has been fixed by manually adding it, the main question stays however, does this affect more code? This needs checking...


Related issues

Related to ET: Legacy Development - Bug #65: Server address doesn't contain port Fixed 20.07.2012
Related to ET: Legacy Development - Bug #246: Dedicated server consumes 100% CPU Fixed 13.03.2013
Related to ET: Legacy Development - Bug #501: Port gethostbyname() to getaddrinfo() Fixed 01.02.2014
Related to ET: Legacy Development - Feature #514: ET:L master server Fixed 17.02.2014

Associated revisions

Revision d6ade049
Added by Radegast about 6 years ago

general: NET_AdrToString returns address with port again, fixes #65, refs #49

Revision 48a14a37
Added by Radegast about 6 years ago

general: removed all occurrences of NET_AdrToStringwPort, refs #49

Revision 8bf9bc98
Added by Radegast almost 6 years ago

generic: show IPv6 addresses using NET_AdrToString, refs #49

Revision a2833e83
Added by IR4T4 over 5 years ago

client: NET_AdrToStringwPort replaced by NET_AdrToString refs #49, refs
#215

History

#1 Updated by Radegast over 6 years ago

  • % Done changed from 0 to 10

Ilm’s patch which changed some occurances of NET_AdrToString to NET_AdrToStringwPort was reverted in 0e1679b0, but that is on the client side.

#2 Updated by IR4T4 about 6 years ago

  • Priority changed from High to Immediate

#3 Updated by Radegast about 6 years ago

  • Status changed from New to In Progress
  • Assignee set to Radegast
  • % Done changed from 10 to 40

ioquake3’s NET_AdrToString function was replaced by the original ET-GPL code in d6ade049. This will possibly break some things, especially on the server side, so I’m not closing this bug report yet.

#4 Updated by Radegast about 6 years ago

  • Subject changed from Fix NET_AdrToString and associated code to Fix NET_AdrToString and associated code for IPv6 addresses
  • Category changed from Server to General
  • Priority changed from Immediate to Low
  • % Done changed from 40 to 90

All the occurrences of NET_AdrToStringwPort were replaced with the older NET_AdrToString. The only remaining thing to do is to add port even for IPv6 addresses in NET_AdrToString.

#5 Updated by IR4T4 about 6 years ago

  • Status changed from In Progress to Feedback

#6 Updated by IR4T4 almost 6 years ago

  • Target version changed from 2.70rc1 to 2.75

#7 Updated by IR4T4 almost 6 years ago

Note: The IPv4 is part of players’ config string in the mod code and may break 2.60 compatibility if we just switch.

#8 Updated by IR4T4 almost 6 years ago

Replace gethostbyname() with getaddrinfo().

#9 Updated by IR4T4 over 5 years ago

  • Subject changed from Fix NET_AdrToString and associated code for IPv6 addresses to Fix NET_AdrToString and associated code for IPv6 addresses / fix q3 net code merge
  • Priority changed from Low to Normal
  • Target version changed from 2.75 to 2.71rc1


- fix the wPort function in CL_GlobalServers_f
- NET_AdrToString/NET_AdrToStringwPort

#10 Updated by IR4T4 over 5 years ago

  • Target version changed from 2.71rc1 to 2.71rc2

#11 Updated by IR4T4 over 5 years ago

  • Target version changed from 2.71rc2 to 2.77

#12 Updated by Spyhawk over 4 years ago

  • Related to Bug #501: Port gethostbyname() to getaddrinfo() added

#13 Updated by Radegast over 3 years ago

#14 Updated by IR4T4 over 3 years ago

  • Assignee deleted (Radegast)

#15 Updated by IR4T4 about 3 years ago

  • Target version changed from 2.77 to ALL

#16 Updated by IR4T4 about 3 years ago

Currently all existing mods use IPv4 in playerinfo and configstrings. They can’t deal with IPv6 IPs. For now there is no need to use IPv6.

#17 Updated by IR4T4 almost 2 years ago

  • Status changed from Feedback to Fixed
  • Target version changed from ALL to 2.76
  • % Done changed from 90 to 100

#18 Updated by IR4T4 about 1 year ago

  • Subject changed from Fix NET_AdrToString and associated code for IPv6 addresses / fix q3 net code merge to Test NET_AdrToString and associated code for IPv6 addresses / fix q3 net code merge
  • Status changed from Fixed to In Progress
  • Target version changed from 2.76 to ALL
  • % Done changed from 100 to 50

Test IPv6 related code.

Also available in: Atom PDF