Bug #538

*Reminder* Too many pk3s in path cause trouble/server crash

Added by IR4T4 about 5 years ago. Updated 5 months ago.

Status:New% Done:

100%

Priority:NormalSpent time:-
Assignee:-
Category:Server
Target version:ALL
OS: Arch:

Description

Update: This file is kept as reminder - we can’t fix this

You should get a warning at start when pk3 limit is reached.

I’ve had a crash when I did start a listen server by the menu. This happens when game pathes are populated with tons of pk3 files.
Actually there is a direct known limit: the size of CS1 (8192)
CS1 stores all the pk3 information and when this info size is over 8192 chars we are in trouble. I my case the pk3 including our campaigns wasn’t loaded. Since we don’t know in which order all the pk3 info is put into CS1 and any other pk3 might be affected too - this error is flexible. For example: A missing shader data pk3 info will cause gfx glitches.

Option A:
Print a warning/don’t start the game when the real used size of CS1 is reaching our limit

Option B:
Add an additional CS when CS1 is overloaded ... This increases the configstring in general (network!) and might break 2.60 compatibility.


Related issues

Related to ET: Legacy Development - Bug #588: MAX_GAMESTATE_CHARS exceeded Invalid 19.09.2014
Related to ET: Legacy Development - Bug #638: Creating campaign server in Host Menu causes a crash Fixed 20.11.2014
Related to ET: Legacy Development - Bug #604: Location names aren't updated Fixed 23.10.2014

Associated revisions

Revision 53bf1e8f
Added by IR4T4 over 4 years ago

server: warn admins when total CS is near limit refs #538

Revision 18a370f4
Added by IR4T4 over 4 years ago

server: fix CS warning (test commited), separate warning for oversized
systeminfo CS refs #538

History

#1 Updated by Mateos almost 5 years ago

I’d go for Option A, localhost crash happens with not that many PK3s, but when you have even more it can crash the client on a map load...

See:
http://forums.warchest.com/showthread.php/39844-Broken-ETPub-based-mods

Basically "couldn’t reopen <insert main game or mod PK3 file>".

Regarding option B, I don’t think it’s a good idea, but exclude any file without a BSP or SCRIPT file?

#2 Updated by IR4T4 almost 5 years ago

  • Description updated (diff)

#3 Updated by IR4T4 almost 5 years ago

  • Related to Bug #588: MAX_GAMESTATE_CHARS exceeded added

#4 Updated by Spyhawk over 4 years ago

  • Related to Bug #638: Creating campaign server in Host Menu causes a crash added

#5 Updated by Spyhawk over 4 years ago

  • Related to Bug #604: Location names aren't updated added

#6 Updated by IR4T4 over 1 year ago

  • Subject changed from Too many pk3s in path cause trouble to Too many pk3s in path cause trouble/server crash
  • % Done changed from 0 to 100

#7 Updated by IR4T4 over 1 year ago

  • Description updated (diff)

#8 Updated by IR4T4 5 months ago

  • Subject changed from Too many pk3s in path cause trouble/server crash to *Reminder* Too many pk3s in path cause trouble/server crash

Also available in: Atom PDF