Bug #555

renderer2: discolored puddle in Radar

Added by ZTM almost 5 years ago. Updated over 1 year ago.

Status:Fixed% Done:

100%

Priority:NormalSpent time:-
Assignee:-
Category:Client
Target version:renderer2
OS: Arch:

Description

There is an incorrectly renderer puddle shader in Radar in r2 (on road near edge of map, run `setviewpos 482 3875 1417 96`). This is a special case handled by opengl1’s tr_shader.c. r2 needs an equivalent.

src/renderer/tr_shader.c: ParseStage

// if shader stage references a lightmap, but no lightmap is present
// (vertex-approximated surfaces), then set cgen to vertex
if (stage->bundle[0].isLightmap && shader.lightmapIndex < 0 &&
stage->bundle[0].image[0] == tr.whiteImage)
{
stage->rgbGen = CGEN_EXACT_VERTEX;
}

Related issues

Related to ET: Legacy Development - Task #1029: renderer2: Mirror all R1 shaders in R2 Fixed 22.04.2017
Related to ET: Legacy Development - Bug #552: renderer2: missing foliage support Fixed 01.08.2014

Associated revisions

Revision 275c6fba
Added by thunder over 1 year ago

renderer2: fix reflections on Radar ponds

Revision 30da8a09
Added by ryven over 1 year ago

renderer2: add foliage, fix surface vertex lit

adds support for vbo/software foliage (r_vboFoliage)
fixes surface vertex lighting
refs #552, #555

Revision 063609b8
Added by ryven over 1 year ago

renderer2: extend lightmap by vertex support

Adds lightmap by vertex support for other render
funcs. Refactor things to eliminate duplicates.
refs #555

Revision 240527c9
Added by ryven over 1 year ago

renderer2: fix sky shader vertex lighting issue

Made sky shader to be excluded from the vertex lighting fixer,
that adjusts cgen/agen values based on a number of arguments.
Skybox ain’t need that anyways.

refs #555

History

#1 Updated by IR4T4 almost 5 years ago

  • Target version set to renderer2

#2 Updated by Radegast over 4 years ago

  • Description updated (diff)

#3 Updated by thunder about 2 years ago

  • Related to Task #1029: renderer2: Mirror all R1 shaders in R2 added

#4 Updated by thunder about 2 years ago

  • Assignee set to thunder

will implement this one

#5 Updated by IR4T4 over 1 year ago

  • Assignee deleted (thunder)

This issue is related to our foliage issue. There are no rain drops painted (see r1) and this is done with foliage tech.

#6 Updated by IR4T4 over 1 year ago

  • Related to Bug #552: renderer2: missing foliage support added

#7 Updated by IR4T4 over 1 year ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

Fixed.

Thank you ryven.

Also available in: Atom PDF