Bug #558

NUMLOCK status fails

Added by Mateos almost 4 years ago. Updated almost 2 years ago.

Status:Fixed% Done:

100%

Priority:Urgent
Assignee:-
Category:Client
Target version:2.76
OS:Linux Arch:

Description

Compiled just now, tested: in the chat box or in the console, using the keypad numbers double-print each number, but not the math symbols.

Tested all numbers and symbols.


Related issues

Related to ET: Legacy Development - Feature #332: Port client to SDL 2 Fixed 19.08.2013
Related to ET: Legacy Development - Task #891: Update SDL2 to version 2.04 Fixed 24.11.2015

Associated revisions

Revision fe06b4a1
Added by Jacker almost 4 years ago

client: removed an old hack for the numpad, refs #558

Revision b5751b97
Added by IR4T4 almost 4 years ago

sdl: SDLToQ3Key mapping optimized. Don’t map to keypad control keys
when we want numbers refs #558

Revision 7504c75a
Added by Spyhawk almost 2 years ago

sdl: removed obsolete KMOD_NUM hack, refs #558 #680

History

#1 Updated by IR4T4 almost 4 years ago

  • Category set to Client
  • Target version set to 2.71

Confirmed. Keypad has issues. It’s not only the double print of numbers.

#2 Updated by IR4T4 almost 4 years ago

#3 Updated by IR4T4 almost 4 years ago

  • % Done changed from 0 to 10

Matoes, please run current code with NUM disabled (no LED at start). In that case keypad should be fine.

#4 Updated by Mateos almost 4 years ago

Just compiled and tried, I don’t see any difference: on double-printed, off nothing happening (normal behavior).

#5 Updated by Jacker almost 4 years ago

try it now please, at the least in my system it works correctly..

#6 Updated by Mateos almost 4 years ago

Tested and it is fine now, no double-print, and enabling/disabling the num pad work as expected.

#7 Updated by IR4T4 almost 4 years ago

  • % Done changed from 10 to 80

#8 Updated by IR4T4 almost 4 years ago

Mateos wrote:

Tested and it is fine now, no double-print, and enabling/disabling the num pad work as expected.

Did you check this with LED status on/off (I know you are on Win). As far as I can see num lock state isn’t set in linux x11 SDL2 code.

#9 Updated by Mateos almost 4 years ago

I’ve tested with both on/off modes during the run time.

#10 Updated by Jacker almost 4 years ago

Num lock status is checked every time via win api in the cl_input, thats why it works on windows at least..

#11 Updated by IR4T4 almost 4 years ago

x11 systems can only use the numpad properly when NUM is off at start of ETL.

#12 Updated by Jacker over 3 years ago

  • Status changed from New to Fixed
  • % Done changed from 80 to 100

#13 Updated by IR4T4 over 3 years ago

  • Status changed from Fixed to Confirmed
  • OS set to Linux

@Jacker Linux/x11 has still issues SDL2 doesn’t recognize the numlock status.

#14 Updated by Jacker over 3 years ago

Have you tested this lately? I updated the numlock code for unix as well..

#15 Updated by IR4T4 over 3 years ago

Tested. No luck. It’s definately SDL2 related.

#16 Updated by IR4T4 over 3 years ago

  • Subject changed from Using keypad double-prints the numbers to NUMLOCK status fails / using keypad double-prints the numbers-

#17 Updated by IR4T4 over 3 years ago


SDL2 doesn’t detect NUMLOCK status at start of application on x11 - for the release we might add the patch attached at
https://bugzilla.libsdl.org/show_bug.cgi?id=2736

#18 Updated by IR4T4 over 3 years ago

  • Priority changed from Normal to High

#19 Updated by IR4T4 over 3 years ago

  • Target version changed from 2.71 to 2.72

#20 Updated by IR4T4 over 3 years ago

  • Target version changed from 2.72 to 2.77

#21 Updated by IR4T4 over 2 years ago

  • Priority changed from High to Urgent
  • Target version changed from 2.77 to ALL

Waiting for SDL 2.04.

#22 Updated by IR4T4 over 2 years ago

  • Related to Task #891: Update SDL2 to version 2.04 added

#23 Updated by Spyhawk almost 2 years ago

This should have been fixed in SDL 2.0.4 on all platform. See https://bugzilla.libsdl.org/show_bug.cgi?id=3125

Let’s check if some additional changes are required in our code.

#24 Updated by Spyhawk almost 2 years ago

  • Subject changed from NUMLOCK status fails / using keypad double-prints the numbers- to NUMLOCK status fails
  • Target version changed from ALL to 2.76

#25 Updated by Spyhawk almost 2 years ago

Numlock status seems indeed fixed.

However, fireteam control doesn’t take it into account for some reason (console and chat are ok): https://dev.etlegacy.com/boards/3/topics/2714?r=2715#message-2715

#26 Updated by Spyhawk almost 2 years ago

  • Status changed from Confirmed to Fixed

Also available in: Atom PDF