Bug #621

renderer2: Skybox issues on some maps

Added by IR4T4 over 4 years ago. Updated about 1 year ago.

Status:Fixed% Done:

100%

Priority:LowSpent time:-
Assignee:-
Category:Client
Target version:renderer2
OS: Arch:

Description

Some maps don’t show the skybox

- UJE Ambush
- ROP RIVER
- et dam (Bramberg)
- bridges
- decoder beta 4
...


Related issues

Related to ET: Legacy Development - Bug #552: renderer2: missing foliage support Fixed 01.08.2014
Related to ET: Legacy Development - Task #924: Test cube maps New 06.04.2016
Related to ET: Legacy Development - Bug #1045: renderer2: Lower clouds speed / fix animation speed Confirmed 08.07.2017
Related to ET: Legacy Development - Bug #1051: Skybox problem on Italy map Invalid 22.07.2017

Associated revisions

Revision a865a0e3
Added by IR4T4 almost 2 years ago

renderer2: fix image loading of inner-/outerbox, hotfix to avoid eye
cancer on maps using these boxes refs #621

Revision 36957a89
Added by IR4T4 almost 2 years ago

renderer2: merged some code & structure from r1, notes refs #621

Revision 4c551d4a
Added by IR4T4 over 1 year ago

renderer2: fix portal skies (see map marketgarden f.e.) refs #621 and
other mark leaves issues

It turned out the code part at end of loop has never been reached when
it should.

Revision af284334
Added by thunder over 1 year ago

renderer2: Fix maps (decoder/uje_ambush but not all!) creating sky by
skyparams refs #621

There are still maps not showing a proper sky. See rop_river f.e.

Revision 99baf1cb
Added by IR4T4 over 1 year ago

renderer2: fix innerbox image loading refs #621

Revision 0ac8a137
Added by IR4T4 over 1 year ago

renderer: dirty hack to ensure sky cubemap is created with proper
dimension refs #621

Revision 60ee9f79
Added by ryven over 1 year ago

r2: fix skyshader issue with clampmap’ed textures

clampmap’ed textures in renderer2 were not positioned
correctly in skyboxes due to getting wrong wrap setting
on image initialization
refs #621

History

#1 Updated by IR4T4 over 4 years ago

  • Subject changed from Skybox issues on some maps to renderer2: Skybox issues on some maps

#2 Updated by RaFaL over 4 years ago

For me it looks like those maps dont have skybox at all just 1 texture
r_fastsky 0 fixes it

#3 Updated by IR4T4 over 4 years ago

r_fastsky is no fix - it’s just the current option to play those maps without getting eye cancer.

#4 Updated by IR4T4 over 4 years ago

  • Related to Bug #552: renderer2: missing foliage support added

#5 Updated by IR4T4 over 4 years ago

  • Description updated (diff)

#6 Updated by IR4T4 over 2 years ago

#7 Updated by IR4T4 about 2 years ago

  • Related to Bug #1045: renderer2: Lower clouds speed / fix animation speed added

#8 Updated by IR4T4 almost 2 years ago

  • Related to Bug #1051: Skybox problem on Italy map added

#9 Updated by IR4T4 almost 2 years ago


sky outerbox and innerbox are not drawn see Tess_StageIteratorSky DrawBox/DrawBoxInner
outerbox sample maps: decoder_beta4 uje_ambush (I haven’t found a map where innerbox is used)

portalskies don’t work (see RDF_SKYBOXPORTAL which isn’t fully ported and not set in r2)
current error: caught OpenGL error: GL_INVALID_ENUM in file /home/olaf/ETL/etlegacy/src/renderer2/tr_shade.c line 445
sample map: uje_marketgarden

#10 Updated by IR4T4 over 1 year ago

  • Status changed from New to Confirmed
  • % Done changed from 0 to 40

#11 Updated by IR4T4 over 1 year ago

  • % Done changed from 40 to 60

Some maps don’t show proper sky textures. Looks like wrong dimensions are used. This might be related to tga textures ...


- uje_the_best
- rop_river
- uje_amsterdam

Are there any maps with innerboxes?

#12 Updated by IR4T4 over 1 year ago

  • Priority changed from Normal to Low
  • % Done changed from 60 to 80

As far as I can see all the skybox and fog issues are fixed. R2 starts getting playable


- Fix/scale wrong image size
The textures to create sky cubemaps have to be of same dimensions but some maps contain smaller bottom textures to save space.
At present we are loading the first texture for this image again and in most cases this does the trick - players don’t see the bottom anyway.
See https://dev.etlegacy.com/projects/etlegacy/repository/revisions/0ac8a137f3a4704df85564b5c64b26535c2a7c24

- Fix texture rendering of images (circle view)

#13 Updated by IR4T4 about 1 year ago

  • Status changed from Confirmed to Fixed
  • % Done changed from 80 to 100

Also available in: Atom PDF