Bug #71

Rework of servercache.dat / fix favourites in browserlist

Added by IR4T4 almost 7 years ago. Updated over 5 years ago.

Status:Fixed% Done:

100%

Priority:NormalSpent time:-
Assignee:IR4T4
Category:Client
Target version:2.71rc2
OS: Arch:

Description

As far as I know this feature doesn’t work properly.


Related issues

Related to ET: Legacy Development - Bug #315: Scroll list and mark favs don't work on higher r_mode set... Fixed 24.06.2013
Related to ET: Legacy Development - Bug #585: Make favorites work on 32/64bit Fixed 19.09.2014
Duplicates ET: Legacy Development - Bug #11: Fix adding server to favourites Invalid 02.03.2012

Associated revisions

Revision 520152c4
Added by IR4T4 over 6 years ago

client: servercache.dat renamed to favcache.dat & freed of global server
data refs #71

Revision 721c6b11
Added by IR4T4 about 6 years ago

ui: ui_serverX cvars removed (16 in total), new console command /listfav
(WIP) refs #71

Revision eef5fc66
Added by IR4T4 almost 6 years ago

client: write favourite servers when they are added/removed refs #71

Revision ec90723b
Added by IR4T4 almost 6 years ago

ui: delete all favourites (gui prototype) refs #71

Revision bd7c90d3
Added by IR4T4 over 5 years ago

client: delete all favourites refs #71, more screen constants in ui,
code style

Revision 84fc66f9
Added by IR4T4 over 5 years ago

client: LAN_RemoveServer adjusted - make delete favourites actually work
refs #71

History

#1 Updated by Radegast almost 7 years ago

See my comment under issue #11. I wanted to make a single list of favourite servers, but I was told that it makes more sense when they are separated for each mod.

#2 Updated by IR4T4 almost 7 years ago

I see ... well from player side it doesn’t matter which mod is used. See target version of this ticket. We don’t have to extract this issue now ... let’s keep it as reminder

#3 Updated by morsik over 6 years ago

who uses this anyway? ;P

#4 Updated by Radegast over 6 years ago

morsik wrote:

who uses this anyway? ;P

I do

#5 Updated by IR4T4 over 6 years ago

morsik wrote:

who uses this anyway? ;P

All new players do too

#6 Updated by Radegast over 6 years ago

  • Assignee set to Radegast

The way it should be done is to show favourites in one place, but add a "Mod" column, so it easy to see what each server runs. This column should be added to the main server browser too.

#7 Updated by Mateos over 6 years ago

morsik wrote:

who uses this anyway? ;P

Hum... Hmm... Me

But I use it only when I have to switch from a server to an other and change my nick between. Also avoids to have the whole list just to search and find a single server

#8 Updated by IR4T4 over 6 years ago

  • Subject changed from Fix favourites in browserlist to Rework of servercache.dat / fix favourites in browserlist

servercache.dat contains global servers and favourites data info.
It doesn’t make sense to store and read global server data - we start with an empty list in the server browser and I don’t think we should change that.


rename the file to favcache.dat (in case ET profiles are copied)
don’t read/write global data
write favcache.dat when a favourite server has been added/removed - not on shutdown
make sure favourites management via the menus does the job (doesn’t work with widescreen atm)
load favourites ONCE on start (and not on map change/restart) won’t do, it’s also mod related
add a 'delete all favourites’ button ?
sort by favs ? see filter

#9 Updated by IR4T4 almost 6 years ago

  • Status changed from New to In Progress
  • Assignee changed from Radegast to IR4T4
  • Target version changed from 2.75 to 2.78

#10 Updated by IR4T4 almost 6 years ago

  • % Done changed from 0 to 80

Basically favourites are ready to use.

#11 Updated by IR4T4 over 5 years ago

  • Status changed from In Progress to Fixed
  • Target version changed from 2.78 to 2.71rc2
  • % Done changed from 80 to 100

A button to delete all favourites has been added.

Keep in mind:

- The first filter 'Source:' (set to favourites) in the player online menu is quite handy
- Favourites are mod related - each started mod has got it’s own favourites file/list (also kept for compatibility reasons)

#12 Updated by Spyhawk almost 4 years ago

  • Related to Bug #585: Make favorites work on 32/64bit added

Also available in: Atom PDF