Bug #750

Commander sounds volume is too low

Added by Dragonji over 4 years ago. Updated almost 4 years ago.

Status:Fixed% Done:

100%

Priority:HighSpent time:-
Assignee:-
Category:Client
Target version:2.74
OS: Arch:

Description

In comparision with 2.60b, commander sounds in ET:L are barely audible. Raise their volume to match to vanilla’s default.

Associated revisions

Revision fc014da0
Added by IR4T4 over 4 years ago

client: print more info about sound when format is 'malformed’ refs #750

Revision f7d59925
Added by Spyhawk about 4 years ago

client: do not overwrite channel volume variable, refs #750

Revision d2e98203
Added by Spyhawk almost 4 years ago

client: make s_musicVolume independent from s_volume, refs #750

Revision dcea48fc
Added by Spyhawk almost 4 years ago

client: fixed non spatialized sounds normalized twice, fixes #750

History

#1 Updated by Saukko over 4 years ago

  • Target version set to 2.72

I can confirm this and also was mentioned by some other ET:L users.

-*S

#2 Updated by Saukko over 4 years ago

  • Target version changed from 2.72 to 2.78

#3 Updated by Spyhawk over 4 years ago

  • Status changed from New to Confirmed

#4 Updated by Spyhawk over 4 years ago

  • Target version changed from 2.78 to 2.74

#5 Updated by IR4T4 over 4 years ago

  • Priority changed from Low to Normal

#6 Updated by IR4T4 over 4 years ago

  • Priority changed from Normal to High

#7 Updated by Spyhawk about 4 years ago

Commit of interest: 572cefcf7c134be34af47be35140d5b8765e6fee, later reverted in cc3ba71c0e5b112a779a1e0e3aab4279043a9e60.

Haven’t had a look (I can’t reproduce this issue), but it might be related.

#8 Updated by Saukko about 4 years ago

I have been able to reproduce this since... Long time. It’s rather annoying since it affects the ability to hear those announcements during big firefights. Could it be OS related then or some CVAR? I tried some CVARs but nothing changed. Or if that’s the commit... We can always try out. I’m at work and will be busy for the rest of the day so I can’t try it out.

-*S

#9 Updated by Mateos about 4 years ago

This code... Calculating twice the same, put in two variables... The point?

Maybe these two removed values where > 1, and so removing them have lowered the volume value?

#10 Updated by Saukko about 4 years ago

Alright I tried this out. By removing rvol and lvol like in the commit, the problem didn’t occur anymore. Commander sounds were fine after that. But if this causes other issues... this should be fixed correctly.

-*S

#11 Updated by Spyhawk about 4 years ago

  • Status changed from Confirmed to Feedback
  • % Done changed from 0 to 50

Possible fix pushed - feedback needed!

There were two variables ('r’) with the same name in the same function. The first one likely conflicted with the 'right’ channel volume - I just renamed it to avoid overwriting the second in memory.

#12 Updated by Saukko about 4 years ago

  • Status changed from Feedback to Fixed
  • % Done changed from 50 to 100

The fix did the trick for me, so it should do for others too.
Closing it as fixed. If the problem still occurs, post here.

-*S

#13 Updated by Saukko about 4 years ago

This still occurs in other mods. Legacy seems fine.

-*S

#14 Updated by Spyhawk about 4 years ago

  • Status changed from Fixed to New
  • % Done changed from 100 to 50

#15 Updated by Dragonji about 4 years ago

This is really weird but volume is okay with Legacy mod and definitely too low with every other mod.

#16 Updated by Mateos about 4 years ago

Could it be Legacy then, which would be too loud?

Or is the sound volume the same between ETL and Vanilla with Legacy mod, and lower only with ETL for other mods?

#17 Updated by Spyhawk about 4 years ago

I am unable to reproduce this issue.

Previous change fixed a variable overwrite (2 'r’ variables in the same function), which apparently improved the situation a bit.

#18 Updated by jayd almost 4 years ago

I can reproduce this issue on Windows 8.1, in a server running the silEnT mod. Can I do anything to help? I’d be willing to let a dev remote into my computer and do some troubleshooting and such to find the root cause of the problem.

#19 Updated by Dragonji almost 4 years ago

Check if you can reproduce the issue on Legacy mod.

#20 Updated by kimi almost 4 years ago

Win7 64 vanilla ET client etlegacy mod ⇒ sounds good
Win7 64 ET legacy client etlegacy mod ⇒ too low

#21 Updated by IR4T4 almost 4 years ago

  • Status changed from New to Feedback

#22 Updated by IR4T4 almost 4 years ago

  • Target version changed from 2.74 to 2.78

We need feedback about this after the 2.73 release → moved to 2.74

#23 Updated by Spyhawk almost 4 years ago

  • Status changed from Feedback to Confirmed

The issue somewhat reappeared on my system for some reason (Legacy mod).

And the issue seems related to the s_volume setting. With the default 0.8 value, the commander voice volume is all right, but when set to a lower value (f.e. 0.25) it is too low compared to other "effects" sounds.

On a sidenote, the music volume (s_musicvolume) is highly dependent on the s_volume slider too. If s_volume is set to 0.8, then s_musicvolume set to 0.25 means "set music to 25% of the 0.8 sound volume".

#24 Updated by Dragonji almost 4 years ago

Spyhawk wrote:

On a sidenote, the music volume (s_musicvolume) is highly dependent on the s_volume slider too. If s_volume is set to 0.8, then s_musicvolume set to 0.25 means "set music to 25% of the 0.8 sound volume".

I remember reporting this more than half a year ago but people on IRC said they couldn’t reproduce

#25 Updated by Spyhawk almost 4 years ago

Dragonji wrote:

I remember reporting this more than half a year ago but people on IRC said they couldn’t reproduce

I could reproduce it, but we never opened a ticket for that issue. Should now be fixed.

  • Check openAL implementation (s_initsound = 2) OK!

#26 Updated by Spyhawk almost 4 years ago

  • Status changed from Confirmed to Fixed
  • % Done changed from 50 to 100

#27 Updated by IR4T4 almost 4 years ago

  • Target version changed from 2.78 to 2.74

Also available in: Atom PDF