Feature #812

Move q3fill fix server side

Added by IR4T4 over 4 years ago. Updated over 1 year ago.

Status:Feedback% Done:

90%

Priority:NormalSpent time:-
Assignee:Aranud
Category:Server
Target version:2.78
OS: Arch:

Description

Currently we fix q3fill exploit in mod game code. We should also add sv_ip_max_clients.

Associated revisions

Revision 693edf20
Added by Aranud about 2 years ago

general: WIP move g_ip_max_clients from game side to sv_ip_max_clients from server side, refs #812

The Fake Ip Connection check is moved to server side. But it is
partially implemented, the rate check doesn’t work.

Moreover, it seem this check can be done earlier, before the new
connection is created. This need more investigation for optimisation.

Revision 31d43266
Added by Aranud about 2 years ago

general: use userinfo to retrieve IP and rate from client for SV_IsFakepConnection + camelCase sv_ip_max_clients + cleanup, refs #812

Revision 8d2f1e13
Added by Aranud about 2 years ago

server: typo + cleanup, refs #812

History

#1 Updated by IR4T4 over 3 years ago

  • Target version changed from 2.78 to 2.75

#2 Updated by Spyhawk over 3 years ago

If we implement this engine side, would it make sense to remove the existing mod code that does the same (g_ip_max_clients)? Legacy mod currently works on 2.60b server, but it’s not designed for it nor can (should?) we ensure it will be the case in the future. The database feature (see #309) will tie Legacy mod to ET:Legacy engine anyway.

#3 Updated by IR4T4 over 3 years ago

From my point of view we can drop g_ip_max_clients when sv_ip_max_clients is done. The legacy mod doesn’t work with punkbuster and there is no reason to run it on 2.60b servers. It seems admins have more reasons to run ET:L servers - see http://dev.etlegacy.com/boards/3/topics/2258?r=2269#message-2269 and most existing popular mods have this functionality.

#4 Updated by Spyhawk over 3 years ago

  • Subject changed from Add q3fill fix server side to Move q3fill fix server side

#5 Updated by IR4T4 over 3 years ago

#6 Updated by IR4T4 over 3 years ago

  • Target version changed from 2.75 to 2.78

#7 Updated by IR4T4 over 2 years ago

  • Blocked by deleted (Feature #309: ET:L database connectivity)

#8 Updated by Aranud about 2 years ago

  • Assignee set to Aranud
  • Target version changed from 2.78 to 2.76
  • % Done changed from 0 to 70

The Fake Ip Connection check is moved to server side. But it is partially implemented, the rate check doesn’t work.

Moreover, it seem this check can be done earlier, before the new connection is created. This need more investigation for optimisation.

#9 Updated by Dragonji about 2 years ago

I’m wondering why this cvar has an ugly name like this. It doesn’t follow the camelCase convention.

For example, ETPub and all derivatives use g_maxConnsPerIP which is gramatically correct and follows the convention.

It’s a good time to discuss this as you rename it anyway to have sv_ prefix.

#10 Updated by Aranud about 2 years ago

Dragonji wrote:

I’m wondering why this cvar has an ugly name like this. It doesn’t follow the camelCase convention.

For example, ETPub and all derivatives use g_maxConnsPerIP which is gramatically correct and follows the convention.

It’s a good time to discuss this as you rename it anyway to have sv_ prefix.

Indeed ! This must be changed to camelCase convention, there is no reason to keep it as it.

#11 Updated by Aranud about 2 years ago

  • % Done changed from 70 to 90

Need feedback !

#12 Updated by IR4T4 about 2 years ago

  • Status changed from New to Feedback

#13 Updated by IR4T4 over 1 year ago

  • Target version changed from 2.76 to 2.78

Also available in: Atom PDF