Bug #834

Sound not looping correctly

Added by yks over 4 years ago. Updated over 4 years ago.

Status:Fixed% Done:

100%

Priority:LowSpent time:-
Assignee:Spyhawk
Category:Client
Target version:2.74
OS: Arch:

Description

The main menu music does not loop correctly - it starts playing again a little early(~1 second). Also with Glock 18 on full auto(very high rate of fire) the is somewhat scrambled due sound looping not working correctly. This issue does not exist with vanilla ET engine.

Setup:
ET:Legacy 2.72 + True Combat:CQB 0.223


Related issues

Related to ET: Legacy Development - Bug #159: Sounds frequently do not play / fix sound issues Fixed 31.12.2012

Associated revisions

Revision 6634c2e3
Added by Spyhawk over 4 years ago

client: fixed looping sound stuttering, refs #834

History

#1 Updated by yks over 4 years ago

  • Priority changed from Normal to High

#2 Updated by yks over 4 years ago

https://youtu.be/24QCQo-3WhE

Video about this looping problem. Bad fps due Fraps but you should understand what’s wrong.

#3 Updated by Spyhawk over 4 years ago

  • Subject changed from Sound not looping correctly on True Combat:CQB to Sound not looping correctly
  • Priority changed from High to Low
  • OS deleted (Windows)

The issue is also present in the Legacy main menu (background music), although it is barely noticeable.

Commits related to S_AddLoopSound() funtion:

See also Coverity ID 1152721: S_AddLoopSounds: Out-of-bounds write to a buffer

Edit: commit of interest: 746f77de3638c65c4de799aea1464b705078f9ef

#4 Updated by Spyhawk over 4 years ago

  • Related to Bug #159: Sounds frequently do not play / fix sound issues added

#5 Updated by Spyhawk over 4 years ago

  • Status changed from New to Feedback
  • Assignee set to Spyhawk
  • % Done changed from 0 to 90

#6 Updated by Spyhawk over 4 years ago

  • % Done changed from 90 to 100

#7 Updated by Spyhawk over 4 years ago

  • Status changed from Feedback to Fixed

Haven’t noticed any side effect after this change, closing now.

Also available in: Atom PDF