Bug #854

Fix stopwatch doesn't start after map end

Added by IR4T4 almost 4 years ago. Updated about 1 month ago.

Status:Fixed% Done:

100%

Priority:HighSpent time:-
Assignee:ryven
Category:Mod QAGAME
Target version:2.77
OS: Arch:

Description

...


Related issues

Related to ET: Legacy Development - Bug #1170: Only campaigns in map list when referee Fixed 17.01.2019

Associated revisions

Revision 4e4bc4c7
Added by Spyhawk almost 4 years ago

misc: added gametype to default configs, refs #854

Revision c3ba6e83
Added by Spyhawk almost 4 years ago

ui: fixed callvote config buttons, refs #854

Revision ddf7fc67
Added by Spyhawk almost 4 years ago

Revert "misc: added gametype to default configs, refs #854"

This reverts commit 4e4bc4c75199ac6cb44a2f00b72545b5bd393531.

Revision 92a0861c
Added by Spyhawk almost 4 years ago

game: restart map when changing gametype, fixes #854

Revision d566a251
Added by Spyhawk almost 4 years ago

misc: removed gametype cvar from configs, refs #854

Revision 5a65335b
Added by ryven 5 months ago

game: fix stopwatch restart after round end

Stopwatch was not restarted after the round end. refs #854

Revision 7494df2d
Added by Spyhawk about 1 month ago

Revert "qcommon: Don’t let VMs change engine latch cvars immediately", refs #854 #1170

This reverts commit bbb68d3af07f3025b10e9f593095f8b51d5c2473.

While preventing a potential rare crash in theory, this commit
introduces way too many side effects and issues to be worth keeping.

It also been pointed out this security fixe is fragile, and has
subsequently also been reverted in ioq3. See:
https://github.com/ioquake/ioq3/commit/738465d677bddac1385da7d6099b58ca0c4a797f

History

#1 Updated by Spyhawk almost 4 years ago

  • Target version changed from 2.74 to 2.78

#2 Updated by Spyhawk almost 4 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

#3 Updated by Spyhawk almost 4 years ago

  • Assignee set to Spyhawk
  • Target version changed from 2.78 to 2.74

#4 Updated by Spyhawk almost 4 years ago

  • Status changed from Fixed to In Progress
  • % Done changed from 100 to 50
Reopening:
  • legacy1 - legacy6 config should change the gametype automatically. A hard map reload should be implemented instead of the buggy map reload (2nd round not starting),
  • the cvar should be locked when the config is loaded,
  • the config should be "unloaded" when any of the cvars in modified by the referee (unlocked + removal of the config string on screen + message "Config WAS UNLOADED DUE TO EXTERNAL MANIPULATION", see G_ConfigCheckLocked).

#5 Updated by IR4T4 almost 4 years ago

  • Target version changed from 2.74 to 2.78

#6 Updated by IR4T4 almost 3 years ago

  • Target version changed from 2.78 to 2.76

#7 Updated by IR4T4 about 1 year ago

  • Target version changed from 2.76 to 2.78

#8 Updated by Spyhawk 6 months ago

  • Priority changed from Normal to High
  • Target version changed from 2.78 to 2.76

This should be high priority for 2.76, as league might be interested in using competition config.

#9 Updated by IR4T4 6 months ago

  • Status changed from In Progress to Feedback
  • Target version changed from 2.76 to 2.78

#10 Updated by IR4T4 5 months ago

  • Target version changed from 2.78 to 2.77

#11 Updated by Spyhawk 5 months ago

Issue is still present in 2.76.

bystr: workaround: load for example 3on3 config then load competitive config and then reload map. I figured it out by trials and errors. That way we had kind-of 3o3 config (kind of coz 3o3 config loading stops in the middle so only half of things load). But I was doing it as a super provisional measure.
That way the stopwatch works and we have kind of 3o3/whatever config
Coz the competitive legacy config doesn’t change many things

Edit: The issue only appears with competition config. It’s free from any bug with the public config. This seems related to the empty 'set nextmap ""' in competition configs.

#13 Updated by Spyhawk 5 months ago

  • Assignee changed from Spyhawk to ryven
  • % Done changed from 80 to 100

#14 Updated by Spyhawk about 1 month ago

Part of the issue is related to #1170 too.
SW mode will enable only once the map is restarted.

#15 Updated by Spyhawk about 1 month ago

  • Related to Bug #1183: broken nextmap command in gametype 4 added

#16 Updated by Spyhawk about 1 month ago

  • Related to deleted (Bug #1183: broken nextmap command in gametype 4)

#17 Updated by Spyhawk about 1 month ago

  • Related to Bug #1170: Only campaigns in map list when referee added

#18 Updated by Spyhawk about 1 month ago

  • Status changed from Feedback to Fixed

Also available in: Atom PDF