Bug #922

Fix timescale div 0 issues

Added by IR4T4 over 3 years ago. Updated over 1 year ago.

Status:Feedback% Done:

100%

Priority:NormalSpent time:-
Assignee:-
Category:General
Target version:2.78
OS: Arch:

Description

timescale/com_timescale 0 value results in undefined behaviour.


Related issues

Related to ET: Legacy Development - Bug #241: Sound and video not matching in demo when timescale is ot... New 07.03.2013
Related to ET: Legacy Development - Bug #1018: Pause feature exit the demo Fixed 08.03.2017

Associated revisions

Revision 3911ebc0
Added by IR4T4 over 3 years ago

server: fix div/0 in SV_RateMsec when com_timescale is 0

Revision df26b893
Added by Spyhawk almost 3 years ago

general: fixed div/0 with com_timescale, refs #922

History

#1 Updated by keMoN about 3 years ago

Talked with Backsnipe about the 2.75 release/ open issues and he mentioned this regarding this ticket:
backsnip3 [10:35 PM]
lol com_timescale 0 value results in undefined behaviour
I’d like to try that
seems pretty easy to fix to me
just force it > 0
nobody uses this command anyway
except for replay thing
to have 3000 fps

#2 Updated by Spyhawk almost 3 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 20

#3 Updated by Spyhawk almost 3 years ago

  • Status changed from Feedback to Fixed
  • Assignee set to IR4T4
  • % Done changed from 20 to 100

Indeed fixed already.

#4 Updated by IR4T4 almost 3 years ago

  • Status changed from Fixed to In Progress

Do a search for timescale and you’ll notice more locations in the code where x/timescale is done.

This issue is actually not fully fixed.

#5 Updated by Spyhawk almost 3 years ago

  • Status changed from In Progress to Feedback

#6 Updated by IR4T4 almost 3 years ago

  • Target version changed from 2.75 to 2.76

Note: We might change the factor from 1 to 0.05 for case timescale 0.

I’ll move this to 2.76. Let’s get some feedback.

#7 Updated by IR4T4 almost 3 years ago

  • Related to Bug #241: Sound and video not matching in demo when timescale is other than 1 added

#8 Updated by IR4T4 over 2 years ago

  • Assignee deleted (IR4T4)

#9 Updated by IR4T4 about 2 years ago

  • Related to Bug #1018: Pause feature exit the demo added

#10 Updated by IR4T4 over 1 year ago

  • Target version changed from 2.76 to 2.78

Also available in: Atom PDF