Bug #97

Task #92: Relase 2.70 rc1

fs_homepath on Windows - use SHGFP_TYPE_CURRENT

Added by morsik over 6 years ago. Updated about 2 years ago.

Status:Fixed% Done:

100%

Priority:Normal
Assignee:-
Category:General
Target version:ALL
OS:Windows Arch:

Associated revisions

Revision e11da545
Added by Radegast over 6 years ago

general: (Windows) fixed crash when homepath is not in a standard location, refs #97

Revision 19af20e8
Added by Spyhawk over 3 years ago

sys: use SHGFP_TYPE_CURRENT as default fs_homepath on windows

Useful if 'My Documents’ has been moved to another drive

History

#1 Updated by Radegast over 6 years ago

  • Assignee set to Radegast
  • % Done changed from 0 to 10

The commit which causes this crash is a87a588c ("Windows path fix")

Confirmed by me on Windows 8 Preview (64bit) and by TheNumb on Windows 7. According to Dragonji, Windows XP is not affected.

cvar_set2 com_errormessage FS_CreatePath: failed to create path "\" 

The only CSIDL identifier which does not crash is CSIDL_APPDATA.

#2 Updated by Radegast over 6 years ago

  • Priority changed from Urgent to Normal
  • Target version changed from 2.70rc1 to 2.75
  • % Done changed from 10 to 40

As a temporary fix, SHGFP_TYPE_DEFAULT is now forced in SHGetFolderPath. The problem is that the file handling code is unable to handle non-standard "My Documents" location. For example, when it is mounted on \\zsf\Home\Documents

#3 Updated by IR4T4 over 6 years ago

  • Subject changed from Windows build crashes to fs_homepath on WIndows - Windows build crashes
  • Target version changed from 2.75 to ALL

#4 Updated by Radegast over 6 years ago

  • Subject changed from fs_homepath on WIndows - Windows build crashes to fs_homepath on WIndows - use SHGFP_TYPE_CURRENT
  • Target version changed from ALL to 2.75

#5 Updated by IR4T4 about 6 years ago

  • Target version changed from 2.75 to ALL

#6 Updated by Dragonji almost 6 years ago

  • Subject changed from fs_homepath on WIndows - use SHGFP_TYPE_CURRENT to fs_homepath on Windows - use SHGFP_TYPE_CURRENT

#7 Updated by Radegast over 5 years ago

  • OS set to Windows

#8 Updated by Radegast over 4 years ago

  • Assignee deleted (Radegast)

#9 Updated by Dragonji over 3 years ago

Isn’t it invalid already?

#10 Updated by Spyhawk about 2 years ago

  • Status changed from New to Fixed
  • % Done changed from 40 to 100

This has been done a long time ago.

Also available in: Atom PDF