Bug #981

Some characters don't appear in chat

Added by Spyhawk over 2 years ago. Updated 4 months ago.

Status:Confirmed% Done:

0%

Priority:NormalSpent time:-
Assignee:-
Category:Mod generic
Target version:2.78
OS: Arch:

Description

The semi-colon (;), quote ("), percentage (%) and UTF characters don’t appear in chat. Check why this is filtered and if this is intended.
  • Percentage is related to the translation system. It is replaced by (.) in the MSG_{Write*,Read*,HashKey} functions;
  • Semi-colon and quote are likely dropped to prevent cmd injection. They are dropped but not replaced by anything.

Related issues

Related to ET: Legacy Development - Bug #591: Legacy issues with vanilla 2.60 Fixed 03.10.2014
Related to ET: Legacy Development - Bug #1037: Remote Code Execution via UTF-8 extended characters Fixed 28.05.2017
Related to ET: Legacy Development - Bug #1072: Games crashes if German Umlauts used in chat Feedback 16.02.2018
Related to ET: Legacy Development - Bug #1224: Chat area allows too long string Fixed 20.03.2019

History

#1 Updated by Spyhawk over 2 years ago

  • Subject changed from Semi-colon don't appear in chat to Semi-colon characters don't appear in chat

#2 Updated by IR4T4 over 2 years ago

Seems intended (but not sure) to deny command injections.

#3 Updated by Dominator56 over 2 years ago

IR4T4 wrote:

Seems intended (but not sure) to deny command injections.

It works normally in vanilla tho, and it never cause issues afaik

#4 Updated by Spyhawk over 2 years ago

  • Subject changed from Semi-colon characters don't appear in chat to Some characters don't appear in chat
  • Description updated (diff)

#5 Updated by Spyhawk over 2 years ago

  • Related to Bug #591: Legacy issues with vanilla 2.60 added

#6 Updated by Spyhawk over 2 years ago

The % character replacement is related to the translation system. I have not be able to find where the semi-colon is dropped. I am not sure the reason is to avoid injection here, as the chat text is internally enclosed by double prime marks.

#7 Updated by IR4T4 about 2 years ago

  • Description updated (diff)

#8 Updated by IR4T4 about 2 years ago

  • Related to Bug #1037: Remote Code Execution via UTF-8 extended characters added

#9 Updated by IR4T4 about 2 years ago

  • Status changed from New to Confirmed

#10 Updated by IR4T4 over 1 year ago

  • Related to Bug #1072: Games crashes if German Umlauts used in chat added

#11 Updated by IR4T4 over 1 year ago

Status:
- (;) , (") and percentage (%) are not displayed
- UTF chars seem to work when chat is initiated via chat window
- console replaces UTF8 chars by .
- intermission chat shows strange behavour when UTF chars are entered (displays random strings from the game)

#12 Updated by IR4T4 8 months ago

  • Target version changed from 2.76 to 2.78

#13 Updated by Spyhawk 4 months ago

  • Related to Bug #1224: Chat area allows too long string added

#14 Updated by Spyhawk 4 months ago

  • Description updated (diff)

Also available in: Atom PDF